changed: D0 length does not change anymore with mhe.direct#359
Merged
Conversation
The vector will always include one additionnal data point compared to the other data windows.
franckgaga
changed the title
D0 length does not change with mhe.directD0 length does not change anymore with mhe.direct
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
- Coverage 98.55% 98.55% -0.01%
==========================================
Files 27 27
Lines 5250 5245 -5
==========================================
- Hits 5174 5169 -5
Misses 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the MHE, the measured disturbance vector$\mathbf{D_0}$ will always include one additional data point compared to the other data windows, both with $p=0$ and $p=1$ cases. The time step of the first data point is $k-N_k$ and the last data point is $k$ , for a total of $N_k+1$ data points. I just ignore the first data point with $p=1$ .
Before this PR, the case with$p=0$ included one additional data point but not $p=1$ , which is overly complex for the user and the maintenance of the code. It will clarify the length of the arguments of the nonlinear custom inequality constraint function for the MHE, which is an upcoming feature.